Re: [VOTE] expand-window Vs maximize-fill-window

Am Sonntag, den 11.10.2009, 17:52 +0300 schrieb Timo Korvola:
> On Sunday 11 October 2009 12:11:10 Christopher Roy Bratusek wrote:
> > Well, expand and maximize are not the same,
> As you can tell from the implementation, they are very similar.  
> Maximize just avoids dock windows whereas expand avoids all windows.
> > maximize-fill-window suggests it would be a maximisation action,
> And it is, because it sets the maximisation flag.  But grow also does 
> that optionally, so not all maximisation actions are named "maximize".  
> Perhaps expand-window is a decent enough name.  OTOH, wouldn't changing 
> the name break people's key bindings?

Well expand-window/maximize-fill-window should not set the maximize-flag
as it's not necessarily maximized, just expanded, by default maximized
windows are not movable, that is not desired for expanded windows, so it
should never set that flag. 

We can provide meta-commands like

(define (maximize-fill-window <args>)
  (expand-window <args>)
  (display-message-with-timeout "<deprecation warning>" 10))

until the release of 1.6.0 and drop them afterwards, also Notes in
README.IMPORTANT and NEWS would be added.


Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]