Re: [VOTE] expand-window Vs maximize-fill-window

Am Samstag, den 10.10.2009, 11:56 +0300 schrieb Timo Korvola:
> On Friday 09 October 2009 18:44:33 Christopher Roy Bratusek wrote:
> > so I added (locally) contract-window,
> Not in the attached patch, which only defines expand-window.
> > a) replace maximize-fill-window by grow-window-* based expand-window
> I don't use it myself, but the implementation of maximize-fill-window 
> seems simple and elegant.  Why would it need to be replaced?  Note that 
> if you call grow-window to all four directions in sequence like in the 
> posted patch, the result may depend on the order.

... You're right, I haven't thought about that

> > b) add maximize-unfill-window (ugly name I know)
> Very ugly for something that makes the window smaller.  contract-window 
> was a better name.

Indeed it is, but it doesn't match the naming scheme, so would it be
better to rename maximize-fill-*-window{,-toggle} to
expand-window-*{,-toggle}? I guess that's more abvious and we have a
pair with better matching names.


Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]