Re: [TODO] Review Patches, please

[Teika Kazura <teika lavabit com>]

Hi.

On Mon, 04 May 2009 17:54:54 +0200, Christopher Roy Bratusek wrote:
> Am Montag, den 04.05.2009, 15:37 +0900 schrieb D M German:
>>  Chris> 2) Display worskpace when cycling
> [...]
> What I meant is that, when you switch a workspace/viewport, that a
> prompt pops up saying "Workspace 1" or "Viewport 0:1" (there 0 is the
> row and 1 the column). Of course also optional.

I uploaded one, which applies to the current GIT repo:
http://sawfish.wikia.com/wiki/Display_worskpace_when_cycling

But it has some loose ends and some enhancements are possible.
One is what Chris referred to: viewport addition. (Currently workspace
only.) Another is workspace name, rather than internal number.

Bugs are that if cycle-switch-workspaces is nil, 
* iconified are not popped up.
* focus is not given. (Compare then- and else- clauses.)
* Displayed workspace should be (seems to me)
  nearest-workspace-with-window, but currently 
  (car (window-workspaces w)).

> Of course also optional.

Let me make it precise: What's optional is to switch viewport and/or
workspace. What is displayed doesn't have to be optional, because its
aim is to supply the necessary clue, as D German, the author, says.

German, or anyone, do you have time to finish it up?

'popup-window-list' is also useful for choosing windows. It deserves
enhancement, too. (I know, but...)

Teika (Teika kazura)