Re: sawfish 1.3.3 & gimme.jl

[Diab Jerius <djerius cfa harvard edu>]

On Sat, 17 Jan 2009 17:04:28 +0900, Teika Kazura wrote:

> Hi Diab Jerius.
> 
> I have uploaded the new version, so please try it.
> 
> I've done:
>   * (require 'sawfish.wm.commands.x-cycle) is added. * Null command
>   string bug fixed.
> 
> If it complains about other unbound variables, then add another
> "require". You can search the appropriate package with "ack".
> 
> Sample session; In the sawfish source directory, I typed $ ack
> "cycle-raise-windows"
> 
> Then it returned.
> 
> ..
> lisp/sawfish/wm/commands/x-cycle.jl
> 40:;; If cycle-raise-windows is enabled, focused window is brought to
> 122:  (defvar cycle-raise-windows t
> 203:      (when cycle-raise-windows
> ..
> 
> OK, defvar is found. So sawfish.wm.commands.x-cycle is the needed one.
> For details, see
> http://sawfish.wikia.com/wiki/Developer%27s_tips
> 
> Good luck!
> 
> Teika kazura

Thanks!

I ran into two more unbound variables (cycle-warp-pointer and cycle-focus-
windows) which were mentioned in sawfish.wm.util.compat as being 
obsolete.  I know little lisp, so I'm not sure what compat.jl is supposed 
to do, but requiring it did not fix the errors. 

Instead, because the variables were marked as obsolete I removed the code 
in gimme.jl which referenced them:


diff -c ~/tmp/Gimme.jl ~/.sawfish/lisp/gimme.jl
*** /home/dj/tmp/Gimme.jl	2009-01-20 09:28:01.000000000 -0500
--- /home/dj/.sawfish/lisp/gimme.jl	2009-01-20 10:04:15.000000000 
-0500
***************
*** 104,115 ****
      (show-window win))
    (when cycle-raise-windows
      (raise-window win))
-   (when cycle-warp-pointer
-     (warp-cursor-to-window win))
    (when (window-get win 'shaded)
!     (unshade-window win))
!   (when (and cycle-focus-windows (window-really-wants-input-p win))
!     (set-input-focus win)))
  
  (define (gimme what name #!optional command)
    (let*
--- 104,111 ----
      (show-window win))
    (when cycle-raise-windows
      (raise-window win))
    (when (window-get win 'shaded)
!     (unshade-window win)))
  
  (define (gimme what name #!optional command)
    (let*




Diab