Re: [PATCH 2/2] save/load readline history in interactive mode

On Sat, Aug 22, 2009 at 10:26:28PM +0200, Christopher Roy Bratusek wrote:
> Am Samstag, den 22.08.2009, 22:20 +0200 schrieb Jürgen Hötzel:
> > Hi Christopher,
> > On Sat, Aug 22, 2009 at 09:43:56PM +0200, Christopher Roy Bratusek wrote:
> > > Some descriptive text for man/news and ChangeLog would be nice :)
> > 
> > Messages a meant to be applied via "git am" (they contain proper git
> > messages). Or do you mean they are not descriptive "enough"?
> > 
> > You manually maintain ChangeLog? Have you considered autogenerating
> Yes I write them by hand.
> > via "git log" like glib/gtk+ maintainers do?
> > 
> I write short commit messages and use the ChangeLog to leave extra
> comments and such

I suggest GTK+/GIT standard commit messages: Quote from GTK+

=== begin example commit ===
Short explanation of the commit

Longer explanation explaining exactly what's changed, whether any
external or private interfaces changed, what bugs were fixed (with bug
tracker reference if applicable) and so forth. Be concise but not too brief.
=== end example commit ===

Personaly i think commit information is not really useful in plain
text files.  Adding references to files and functions as proposed in
"GNU Change Logs Standards" is just crutch for manually maintaining
commit information which is already handled much better by GIT.

ChangeLogs can still be auto-generated for dist tarballs (Like Gtk+
maintainers do)

Users can still browse "short history" via git log --oneline

> What I meant: what do your patches do, you didn't leave a description.
> the first lets us correctly exit and the second seems to introduce
> bash-like readline-history behaviour. right?

Yes. commit message was a bit lazy. I obeyed the multiline commit
message because i thought the intention was obvious.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]