Re: Serious breakage with sawfish 1.3.4

On Tue, Oct 07, 2008 at 11:38:58PM +0300, Timo Korvola wrote:
> Michal Jaegermann <michal harddata com> writes:
> > The problem is that whomever liberally sprinkled '(gpointer)' in
> > various places in source did not check that this is not defined then
> > and did not provide a valid replacement for that case.
> Does r4276 work for you?  I tried to remove most cases of gpointer
> abuse, ....

Yes, the current svn trunk does compile when '--without-gdk-pixbuf'
is used save the following required patch:

--- sawfish-1.3.4/src/images.c~ 2008-10-08 21:50:24.000000000 -0600
+++ sawfish-1.3.4/src/images.c  2008-10-08 22:03:28.000000000 -0600
@@ -1001,6 +1001,9 @@ Tile SOURCE-IMAGE into DEST-IMAGE.
     int src_width, src_height;
     int dst_width, dst_height;
     int x,dst_y;
+#if defined HAVE_IMLIB
+    int src_y;

     rep_DECLARE1(dst, IMAGEP);
     rep_DECLARE2(src, IMAGEP);

Regardless if '--without-gdk-pixbuf' is used or not I see a number
of warnings during a compilation of .jl files.  There are of
"warning: too many arguments ..." type with various functions or
"warning: calling undeclared function `error-handler-function'"
and one:
sawfish/wm/ext/3d-hack.jl:143: In function `3d-redraw':
sawfish/wm/ext/3d-hack.jl:143: warning: unused variable `annotate-points'

That is about all I can tell at the moment.

BTW - is there a way to keep with svn original timestamps on
files?  It is the most annoying when they get reset to a time
of retrieval.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]