Re: enter-exit focus breaks thunderbird/firefox and others. (Was Confirming this bug still exists)

["Dan Merillat" <dan merillat gmail com>]

On Jan 15, 2008 6:01 PM, Janek Kozicki <janek_listy wp pl> wrote:

> with: Menu->Customize->Focus: "enter-only" I couldn't reproduce this,
> however with "enter-exit" I can reproduce this bug.

"sloppy focus" in other window managers - that breaks renaming of
desktop icons as the keystrokes go to the last window the mouse was
in, not the Desktop.

Ok, This isn't the "right" patch, but it works.  Here's the deal -
when a history/completion window pops up, it grabs focus and
highlights it's "first" match.   For some reason, the grab check isn't
working right and the window is getting a 'lost focus' notice, which
causes it to paste the selection.

I'm going to defer to someone with more lisp knowledge at this point,
but this should be enough to   fix the problem the right way.
(Probably search through all args for 'Grab' events, not just the
first?)

On the upside, this DOES defocus when you're over the root window, and
thus you can rename files on the desktop properly.

When debugging lisp, how do I output to the .xsession-errors log?  Or
any log, for that matter.

--- sawfish-1.3.1.orig/lisp/sawfish/wm/focus.jl 2007-07-26
13:55:04.000000000 -0400
+++ sawfish-1.3.1/lisp/sawfish/wm/focus.jl      2008-01-15
20:00:19.000000000 -0500
@@ -139,10 +139,6 @@
        ((pointer-in)
         (when (window-really-wants-input-p w)
           (set-input-focus w)))
-       ((pointer-out)
-        ;; ignore grab/ungrab leave events
-        (when (eq (car args) 'normal)
-          (set-input-focus nil)))
        ((enter-root)
         ;; ensure that any desktop window gets focused
         (set-input-focus w))