Re: [Rhythmbox-devel] DAAP patches

[Jonathan Matthew <jonathan d14n org>]

On Mon, Dec 7, 2009 at 5:45 AM, Jay L. T. Cornwall <jay jcornwall me uk> wrote:
> Hi,
>
> Been a little while since I put these two patches together to resolve a
> couple of shortcomings in the DAAP plugin:
>
> https://bugzilla.gnome.org/show_bug.cgi?id=484881
> https://bugzilla.gnome.org/show_bug.cgi?id=470711

 ...

> What would need doing to get these features added/fixed in Rhythmbox trunk?
> I'm happy to undertake any architectural work needed to knock these patches
> into shape.

Pretty much all of my review comments on the second patch still apply.

For the first, I'd much rather see this fixed in oggdemux to make life
better for GStreamer application developers everywhere, but that's
probably a bit unrealistic. I think it'd be possible to get the same
effect using the GStreamer queue2 element in file-based buffering
mode, rather than adding our own buffering code to the already hacky
source element.