Re: [Rhythmbox-devel] [Final Report] Rhythmbox iPod/MTP Syncing

[Jonathan Matthew <jonathan d14n org>]

On Mon, Aug 17, 2009 at 10:06:11AM -0700, Paul A Bellamy wrote:
> Hi all,
>    Though this is the final day of GSoC, I would like to ask the
> Rhythmbox Community to allow me one more week (since I started a
> couple weeks late).  I would like to continue, testing/debugging and
> making sure my code is as polished, and clean as I possibly can.
>    One of the major issues I was working on last week was that,
> during syncing the UI would hang for a few seconds (while the
> databases were compared).  To overcome that I converted the sync
> function into a daisy-chain of g_idle_add functions, and I set the
> rb_media_player_prefs_update_sync function, to be able to be called
> as an idle_cb (to improve UI responsiveness).  However, with that,
> the way that data is passed between them, and state is preserved
> became a bit wonky.  That is one of the things that I would like to
> spend this week cleaning up.

Sounds like this is something it'd be better to do in a thread.  There's
probably some slight awkwardness if you want to do any RhythmDB queries
as part of this, but hopefully we can find a good solution to that.

>    The other little thing, I would like to fix this week, is to have
> the UI buttons for sync grayed out while it is happening, so that it
> cannot be repeatedly clicked, leading to simultaneous syncs (a very
> bad thing).
>    moch: If you need my code in ASAP, I can send it to you, but if
> there is no rush for the release after 0.12.4, then I would like to
> continue working on my code.

I'm more than happy for you to continue working, and there's no rush for
the next release (it'll probably take about as long as 0.12.4 did, maybe
even longer).

If you're not planning any major changes, though, I think it'd be best
to start looking at integrating your code into the git repo soon, at
least on its own branch.

How have you been managing the code so far?  If you've got a public repo
I can look at, that'd be great, but if you send me a patch or a tarball
that's fine too.

> Thanks all.  It has been a pleasure working with you, and I look
> forward to continuing to contribute to the Rhythmbox project in the
> future.

Thanks for your work so far.  It'll be great to finally have this
feature in Rhythmbox, and I hope there's more to come.