Re: [Rhythmbox-devel] Re: AudioCD patch

Hi James,

James Livingston wrote:
G'day everyone,

Attached is the latest iteration of the audio cd patch. Reports of
success or failure on any non-Linux systems are especially appreciated.

The patch also moved the nautilus-cd-burner dependency from optional to
mandatory. As we depend on a Gnome 2.10 desktop, that shouldn't cause
problems for anyone (hopefully).

I finally found a chance to try this out. Nice work.

A couple comments:

* We should use nautilus_burn_drive_lock to claim the CD device while RB is running. This stops gnome-volume-manager from starting up another application.

* In nautilus-cd-burner 2.13 I've changed NautilusBurnDrive to be a class. Instances of which can emit "device-added" and "device-removed" signals when the "enable-monitor" property is set on the drive object. It should work on both HAL and non-HAL systems.

One of the next things I hope to do in 2.13 is to create a class to replace the use of nautilus_drive_get_list. The list object would be able to monitor drives that are added and removed.

Hopefully, these will simplify things.  What do you think?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]