Re: [Rhythmbox-devel] Rhythmbox archive

[Bastien Nocera <hadess hadess net>]

Hello Jonathan,

On Sat, 2005-06-04 at 10:30 +1000, Jonathan Matthew wrote:
> On Sat, Jun 04, 2005 at 12:45:47AM +0200, Lars Strojny wrote:
> > Hi,
> > 
> > Am Freitag, den 03.06.2005, 10:19 +0100 schrieb Bastien Nocera:
> > [...]
> > 
> > I tried out compiling rhythmbox-0.9 from CVS but it failes with the
> > following. Any hints?
> 
> The attached patch is enough to get it to build for me.
> It'd be nice if this could be committed.  It fixes:
>  - new-style GLib function inlining in rb-refstring

That's fixed in CVS, in a more self-contained way.

>  - pkg-config 0.16 compatibility (which is the problem you were having)

What's the exact problem with this version of pkg-config? From what I
understood, programs should be using PKG in their variable or macros
names, otherwise pkg-config will yell, but we're not doing that.

>  - a very small bit of gcc 4 compatibility

fwrite_unlocked works fine here with gcc4, which version are you using?

> (how do you get cvs diff to include new files if you don't have CVS
> write access? argh.)

Something like that usually does the trick:
diff -u /dev/null myfile-to-be-added >> my-patch

Cheers

-- 
Bastien Nocera <hadess hadess net>