Re: [Rhythmbox-devel] AudioCD Support



That's a result of me rolling-back an inline fix done by Jon McCann
(forgive me if the spelling is off) - it gives me similar errors if
applied, but seems to give you those errors if not applied.

I've attached the patch to fix this, as I probably won't be committing
it to my arch repository (until, at least, someone finds a fix or even
why it's happening).

Apply the patch with "patch -p1 < inline.patch"

Oh, and thanks for running the test program i sent out. What version of
gnome-vfs and hal do you have? what distro are you running? are you
using the default packages for gnome-vfs? I think it not working has
something to do with fedora's gnome-vfs including hal support, when
other distros don't. but i have no idea. I'll work on a workaround soon
(moving back to college tomorrow, so will be a bit busy for the next
couple of days), which will probably be some form of polling.

--matt jones

On Sat, 2005-01-15 at 03:09 +0100, Luca Capello wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi Matt,
> 
> on 01/15/2005 01:04 AM, Matt Jones wrote:
> > That should be fixed now.
> no, new error [2] :-(
> 
> Thx, bye,
> Gismo / Luca
> 
> [2] http://rafb.net/paste/results/fOfYKp36.html
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.5 (GNU/Linux)
> Comment: Using GnuPG with Debian - http://enigmail.mozdev.org
> 
> iD8DBQFB6HtBVAp7Xm10JmkRAkcBAJ0SC8zk5VFJ8YuZJtf3gGEbUnsiNgCffpK/
> aDOp4h5/NMh5uL/l7y/iOo8=
> =PRAS
> -----END PGP SIGNATURE-----
> _______________________________________________
> rhythmbox-devel mailing list
> rhythmbox-devel gnome org
> http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
--- orig/rhythmdb/rb-refstring.c
+++ mod/rhythmdb/rb-refstring.c
@@ -21,15 +21,15 @@
 
 #include <config.h>
 
-#define	G_IMPLEMENT_INLINES 1
-#define	__RB_REFSTRING_C__
-
 #include <glib.h>
 #include <string.h>
 
 GHashTable *rb_refstrings;
 
+#define	G_IMPLEMENT_INLINES 1
+#define	__RB_REFSTRING_C__
 #include "rb-refstring.h"
+#undef G_IMPLEMENT_INLINES
 
 static void
 rb_refstring_free (RBRefString *refstr)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]