Re: [Rhythmbox-devel] Patches for iTunes music share browsing

[Jon Oberheide <jon oberheide org>]

On Wed, 2005-08-10 at 12:04 -0400, Colin Walters wrote:
> On Fri, 2005-08-05 at 12:16 -0400, Charles Schmidt wrote:
[snip]
> > +               buf = g_malloc (file_size);
> > +
> > +               result = gnome_vfs_read (handle, buf, file_size,
> > NULL);
> 
> Hmm...this is potentially pretty large, and remember GLib will just
> abort() if malloc fails.  Is the GMappedFile or whatever interface to
> mmap() in GLib yet?  We should probably use that.

You could always use g_try_malloc() and return if the allocation was
unsuccessful.

Regards,
Jon Oberheide

-- 
Jon Oberheide <jon oberheide org>

Attachment: signature.asc
Description: This is a digitally signed message part