Re: [Rhythmbox-devel] merging monkey-medias

Thanks! Commited, with some slight cosmetic changes and:
- dont unref the decoder seperately in finalize since it is done already
by nureffing the pipeline it is contained in
- unref the src and audiocd_src always in finalize, because they are
reffed in init
- removed the _pause in _play, why was it there?

It uses your backend by default, the 'clean' one is enabled with


lör 2003-05-10 klockan 22.37 skrev Colin Walters:
> On Sat, 2003-05-10 at 14:33, Jorn Baayen wrote:
> > Well, I don't like what you did there as you know 
> I don't like it either :/
> But I still much prefer hacks over not releasing at all.  Not just
> releasing even, but having it easily testable from CVS.
> > - but I see these
> > hacks are necessary for the time being. So what I propose is to include
> > a -gst.c and -gst-tmp.c.
> That sounds like a good solution to me.
> > But, we'd need to update the one in HEAD to include the buffering stuff
> > - could you make a patch for HEAD that only adds the buffering without
> > changing any of the other things? Then we can also add your gst.c and
> > add a configure option.
> Attached.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]