Re: Hard code freeze break: Anjuta - Save doesn't always save

[Vincent Untz <vuntz gnome org>]

Le dimanche 15 mars 2009, à 19:53 +0100, Johannes Schmid a écrit :
> Hi Frederic, hi Vincent!
> 
> > The patch has unrelated stuff in www/htdocs, plugins/git and
> > src/main.c.
> > 
> > Also you went from g_output_stream_write_async to
> > g_file_replace_contents_async, is this necessary for the
> > push/pop/save_count change ?
> 
> I fixed a trivial but wrong (error instead of error->message) warning in
> main.c. I am unaware of any change in the git plugin (that shouldn't
> happen). Same for the htdocs thing - I will add a new clean patch to the
> bug.
> 
> I moved to g_file_replace_contents because it's the right thing to do
> and using g_output_stream added unnecessary custom code. I can make the
> patch using g_output_stream too though if you like that better.

I'd prefer a patch which doesn't move to g_file_replace_contents.
Approval 1 of 2, since it's a data-losing issue.

Vincent

-- 
Les gens heureux ne sont pas pressés.