Feature and string break request



I recently commited the archive backend written by Benjamin Otte to gvfs
svn. Its technically a feature freeze break, but not really as the
feature is hidden and more or less impossible to use as is, and it
doesn't affect anything else (its a separate binary after all).

However, its a really really neat feature when integrated. Basically
you'd click (or right click plus select the right menu item) on an
archive and then you can access it read only from the mount. Much like
how OSX handles dmg files, only it supports zip, tars, isos, etc.

The integration (in its simplest form, suitable for 2.22) is just a
non-visible (for the panel menus) desktop file listing the right
mimetypes as supported that when used (by default on open, or from the
open with submenu) mounts the archive you selected. [Patch attached]

However, this patch adds one string, and breaks the feature freeze. But
since this is an imho very useful feature, and is very unlikely to break
anything else I'd still like to add it to gvfs for gnome 2.22.1. What do
you think about this?

Index: mount-archive.desktop.in.in
===================================================================
--- mount-archive.desktop.in.in	(revision 0)
+++ mount-archive.desktop.in.in	(revision 0)
@@ -0,0 +1,13 @@
+[Desktop Entry]
+Encoding=UTF-8
+_Name=Archive Mounter
+Exec= libexecdir@/gvfsd-archive file=%u
+MimeType=application/x-cd-image;application/x-bzip-compressed-tar;application/x-compressed-tar;application/x-tar;application/x-cpio;application/x-zip;
+Terminal=false
+StartupNotify=false
+Type=Application
+NoDisplay=true
+X-GNOME-Bugzilla-Bugzilla=GNOME
+X-GNOME-Bugzilla-Product=gvfs
+X-GNOME-Bugzilla-Component=archive-backend
+X-GNOME-Bugzilla-Version= VERSION@
Index: configure.ac
===================================================================
--- configure.ac	(revision 1656)
+++ configure.ac	(working copy)
@@ -529,6 +529,7 @@
 programs/Makefile
 test/Makefile
 po/Makefile.in
+mount-archive.desktop.in
 ])
 
 echo 
Index: Makefile.am
===================================================================
--- Makefile.am	(revision 1656)
+++ Makefile.am	(working copy)
@@ -1,5 +1,17 @@
 NULL =
 
+ INTLTOOL_DESKTOP_RULE@
+
+desktop_in_files = mount-archive.desktop.in
+
+desktopdir       = $(datadir)/applications
+if HAVE_ARCHIVE
+desktop_DATA     = mount-archive.desktop
+else
+desktop_DATA     = 
+endif	
+
+
 SUBDIRS = \
 	common \
 	client \
@@ -18,6 +30,7 @@
 
 EXTRA_DIST = \
 	MAINTAINERS		\
+	$(desktop_in_files)     \
 	intltool-extract.in	\
 	intltool-merge.in	\
 	intltool-update.in	\


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]