Re: [Planner Dev] Testing group undo





Richard,

>>re:
>>This sets the label for the menu items as well, which should have the
>>full string for a nice touch, and also the tooltip for the buttons
>>should have to full string. We could check in your patch and add a bug
>>to bugzilla for the other things.

OK,  this new version keeps the menu and tooltips
as the long format describing the undo/redo but the buttons
stay fixed as "Undo" or "Redo" but the button have tool tips
too.

I did it by simply creating extra ui verbs one for buttons (B)
and one menus (M). Then when we actually change tooltips/labels
- just don't play with button labels.

Starting to get used to this gui stuff.

Rgds,
Lincoln.

ps: I've got my new resource use/add dialog about 40% complete.
I've hooked into all the existing resource add stuff with my
new Glade dialog (it has a "Apply" and a "Cancel" button
and have a working dialog (that adjusts 1 task). Now just
have to get the active/inconsistent logic working to adjust
many tasks.

I'm really stuck on sorting the Resource (Resource/Activate/Units )
columns. I want to have these columns sortable but just can't
work out what to do - may have to have non-sorting columns
in my dialog.


Index: data/ui/main-window.ui
===================================================================
RCS file: /cvs/gnome/planner/data/ui/main-window.ui,v
retrieving revision 1.4
diff -u -b -B -p -r1.4 main-window.ui
--- data/ui/main-window.ui	11 Dec 2003 10:52:44 -0000	1.4
+++ data/ui/main-window.ui	14 Feb 2004 01:19:51 -0000
@@ -13,8 +13,10 @@
     <cmd name="EditCopy"         pixtype="stock" pixname="Copy"         _label="_Copy"         _tip="Copy the selection" sensitive="0"/>
     <cmd name="EditPaste"        pixtype="stock" pixname="Paste"        _label="_Paste"        _tip="Paste the clipboard" sensitive="0"/>
     <cmd name="EditClear"        pixtype="stock" pixname="Clear"        _label="Clear"         _tip="Clear the selection" sensitive="0"/>
-    <cmd name="EditUndo"         pixtype="stock" pixname="Undo"         _label="_Undo"         _tip="Undo the last action" sensitive="0"/>
-    <cmd name="EditRedo"         pixtype="stock" pixname="Redo"         _label="_Redo"         _tip="Redo the undone action" sensitive="0"/>
+    <cmd name="EditUndoM"         pixtype="stock" pixname="Undo"         _label="_Undo"         _tip="Undo the last action" sensitive="0"/>
+    <cmd name="EditRedoM"         pixtype="stock" pixname="Redo"         _label="_Redo"         _tip="Redo the undone action" sensitive="0"/>
+     <cmd name="EditUndoB"         pixtype="stock" pixname="Undo"         _label="_Undo"         _tip="Undo the last action" sensitive="0"/>
+    <cmd name="EditRedoB"         pixtype="stock" pixname="Redo"         _label="_Redo"         _tip="Redo the undone action" sensitive="0"/>
     <cmd name="HelpHelp"         pixtype="stock" pixname="Help"         _label="_User Guide"   _tip="Show the Planner User Guide"/>
     <cmd name="HelpAbout"        pixtype="stock" pixname="About"        _label="_About"        _tip="About this application"/>
 
@@ -43,8 +45,8 @@
     </submenu>
 
     <submenu       name="Edit" _label="_Edit">
-      <menuitem    name="EditUndo"     verb=""  accel="*Control*z"/>
-      <menuitem    name="EditRedo"     verb=""  accel="*Control*r"/>
+      <menuitem    name="EditUndoM"     verb=""  accel="*Control*z"/>
+      <menuitem    name="EditRedoM"     verb=""  accel="*Control*r"/>
       <separator/>
       <menuitem    name="EditCut"      verb="" accel="*Control*x"/>
       <menuitem    name="EditCopy"     verb="" accel="*Control*c"/>
@@ -88,8 +90,8 @@
     <separator/>
     <toolitem      name="FilePrint"        verb=""    _label="Print"/>
     <separator/> 
-    <toolitem      name="EditUndo"        verb=""    />
-    <toolitem      name="EditRedo"        verb=""    />
+    <toolitem      name="EditUndoB"        verb=""   _label="Undo" />
+    <toolitem      name="EditRedoB"        verb=""   _label="Redo" />
   </dockitem>
 
   <status>
Index: src/planner-window.c
===================================================================
RCS file: /cvs/gnome/planner/src/planner-window.c,v
retrieving revision 1.7
diff -u -b -B -p -r1.7 planner-window.c
--- src/planner-window.c	10 Feb 2004 05:29:44 -0000	1.7
+++ src/planner-window.c	14 Feb 2004 01:19:59 -0000
@@ -214,8 +214,10 @@ static BonoboUIVerb verbs[] = {
 	BONOBO_UI_VERB ("FileClose",		window_close_cb),
 	BONOBO_UI_VERB ("FileExit",		window_exit_cb),
 
-	BONOBO_UI_VERB ("EditUndo",		window_undo_cb),
-	BONOBO_UI_VERB ("EditRedo",		window_redo_cb),
+	BONOBO_UI_VERB ("EditUndoM",		window_undo_cb),
+	BONOBO_UI_VERB ("EditRedoM",		window_redo_cb),
+	BONOBO_UI_VERB ("EditUndoB",		window_undo_cb),
+	BONOBO_UI_VERB ("EditRedoB",		window_redo_cb),
 	BONOBO_UI_VERB ("EditProjectProps",	window_project_props_cb),
 
 	BONOBO_UI_VERB ("ManageCalendars",      window_manage_calendars_cb),
@@ -1128,17 +1130,25 @@ window_undo_state_changed_cb (PlannerCmd
 	priv = window->priv;
 
 	bonobo_ui_component_set_prop (priv->ui_component, 
-				      "/commands/EditUndo",
+				      "/commands/EditUndoM",
 				      "sensitive", state ? "1" : "0",
 				      NULL);
 	bonobo_ui_component_set_prop (priv->ui_component, 
-				      "/commands/EditUndo",
+				      "/commands/EditUndoM",
 				      "tip", label,
 				      NULL);	
 	bonobo_ui_component_set_prop (priv->ui_component, 
-				      "/commands/EditUndo",
+				      "/commands/EditUndoM",
 				      "label", label,
 				      NULL);
+	bonobo_ui_component_set_prop (priv->ui_component, 
+				      "/commands/EditUndoB",
+				      "sensitive", state ? "1" : "0",
+				      NULL);
+	bonobo_ui_component_set_prop (priv->ui_component, 
+				      "/commands/EditUndoB",
+				      "tip", label,
+				      NULL);	
 }
 
 static void
@@ -1152,16 +1162,24 @@ window_redo_state_changed_cb (PlannerCmd
 	priv = window->priv;
 	
 	bonobo_ui_component_set_prop (priv->ui_component, 
-				      "/commands/EditRedo",
+				      "/commands/EditRedoM",
 				      "sensitive", state ? "1" : "0", 
 				      NULL);	
 	bonobo_ui_component_set_prop (priv->ui_component, 
-				      "/commands/EditRedo",
+				      "/commands/EditRedoM",
 				      "tip", label,
 				      NULL);	
 	bonobo_ui_component_set_prop (priv->ui_component, 
-				      "/commands/EditRedo",
+				      "/commands/EditRedoM",
 				      "label", label,
+				      NULL);	
+	bonobo_ui_component_set_prop (priv->ui_component, 
+				      "/commands/EditRedoB",
+				      "sensitive", state ? "1" : "0", 
+				      NULL);	
+	bonobo_ui_component_set_prop (priv->ui_component, 
+				      "/commands/EditRedoB",
+				      "tip", label,
 				      NULL);	
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]