Re: [Planner Dev] Testing group undo

[Richard Hult <richard imendio com>]

lör 2004-02-14 klockan 01.21 skrev lincoln phipps openmutual net:

> Looking at the code in planner-windows.c I see a label
> is used for the tooltips and the gui. I knocked up an effective
> cludge as shown below. I tried this and its much nicer not
> having the buttons wobble around !.
> 
> Diff is...
> 
> Index: src/planner-window.c
> ===================================================================
> RCS file: /cvs/gnome/planner/src/planner-window.c,v
> retrieving revision 1.7
> diff -u -b -B -p -r1.7 planner-window.c
> --- src/planner-window.c	10 Feb 2004 05:29:44 -0000	1.7
> +++ src/planner-window.c	14 Feb 2004 00:09:53 -0000
> @@ -1137,7 +1137,7 @@ window_undo_state_changed_cb (PlannerCmd
>   				      NULL);	
>   	bonobo_ui_component_set_prop (priv->ui_component,
>   				      "/commands/EditUndo",
> -				      "label", label,
> +				      "label", "Undo",
>   				      NULL);
>   }
> 
> @@ -1161,7 +1161,7 @@ window_redo_state_changed_cb (PlannerCmd
>   				      NULL);	
>   	bonobo_ui_component_set_prop (priv->ui_component,
>   				      "/commands/EditRedo",
> -				      "label", label,
> +				      "label", "Redo",
>   				      NULL);	
>   }

This sets the label for the menu items as well, which should have the
full string for a nice touch, and also the tooltip for the buttons
should have to full string. We could check in your patch and add a bug
to bugzilla for the other things.

I'm planning to go through some patches to comment and commit during the
weekend.

> Are translatable strings are automatically created in planner
> i.e. the "Redo" and "Undo" will get marked for translation ?
> This is one area I'm very hazy about.

_("Redo") and _("Undo") marks for translation :)

/Richard

-- 
Richard Hult                    richard imendio com
Imendio                         http://www.imendio.com