Re: peer review for new committers



On Wed, 2013-08-14 at 18:53 -0400, Colin Walters wrote:
I take the peer review model seriously enough that I'd like my own
patches to be reviewed;

If you're serious about peer review you should consider implementing
e.g. Gerrit. Not being able to commit to your own project's master &
having merges having to pass the test suite by the gateway makes a
significant difference in quality.

This isn't the whole picture, and you're not using GitHub of course, but
a reasonably accessible article about how Gerrit is being used in
OpenStack is here:
http://julien.danjou.info/blog/2013/rant-about-github-pull-request-workflow-implementation

Anyway, I don't know how strong your test suite is, but the peer review
requirement part can certainly be handled by Gerrit. I'd recommend it
for ostree.

AfC
Sydney

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]