Re: peer review for new committers






On Wed, Aug 14, 2013 at 6:53 PM, Colin Walters <walters verbum org> wrote:
Hey, so now that the project has multiple people working on it a bit
more consistently, I want to talk about peer review.

The short version is I'd like ostree to operate on the "group" model.
Concretely, that means patches *don't* have to be reviewed by me -
anyone can review anyone else's patch, and if the reviewer is happy,
push.  If you consider yourself experienced enough in the relevant area
of code to review, then review!

For example, Sjoerd should feel free to review one of Jeremy's patches,
and they can reverse roles.

Feel free to bounce small fixes via pastebin even to a coworker if the
overhead of Bugzilla feels too high.  Particularly for things like
documentation.

Now, I'll obviously be unhappy if big "design" type changes are made
without bringing discussion to a bugzilla or this mailing list; but use
your best judgement!

Sounds good.
 
I take the peer review model seriously enough that I'd like my own
patches to be reviewed; I'm happy for you guys to look for obvious
memory leaks, design issues, naming issues, etc.  Plus it's just more
fun to have other people involved!

So, any takers for this one?

https://bugzilla.gnome.org/show_bug.cgi?id=706031

Done.
 
_______________________________________________
ostree-list mailing list
ostree-list gnome org
https://mail.gnome.org/mailman/listinfo/ostree-list



--
  Jasper


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]