Re: [orca-list] merge request for review

[Alex ARNAUD <aarnaud hypra fr>]

    Many thanks Joanie :-).
    
    
    I personally think if you test the merge request yourself and then
    commit them to master users will sent us feedback if something is
    broken when testing master. As master is here for testing and new
    changes I assume it could be an easy way to ensure merge request are
    heavily tested.
    (If you would like to have help of the community for testing a
    particular merge request don't hesitate to propose it on the mailing
    list or ping me on the bug tracker)
    
    Could you imagine to look at Hypra waiting merge requests too? Note
    that all the merge requests are applied downstream for a while and
    we've seen no issues with them.
    
    Best regards.

Le 17/02/2020 à 14:27, Joanmarie Diggs a écrit :

> Update:
>       Your change actually looks small and sane. I'll give it a spin and
>       merge it assuming no issues. Thanks!
>       
>       
>       --joanie
>       
>       
>       On 2/17/20 13:33, Joanmarie Diggs wrote:
>       
> > It would be great if users could test your
> >         changes and comment on the issue.
> >         
> >         
> >         Regarding issue 86, I assigned that to myself because I plan to
> >         tackle it and it might prove tricky. My time these days is
> >         largely focused on Orca's web support, so non-web-related tasks
> >         are probably better.
> >         
> >         
> >         Thanks!
> >         
> >         --joanie
> >         
> >         
> >         On 2/15/20 06:57, Mike Zhukovskiy via orca-list wrote:
> >         
> > > Hi all,
> > >           
> > >           
> > >           I made a merge request a couple of months back
> > >           
> > >           https://gitlab.gnome.org/GNOME/orca/merge_requests/49
> > >           <https://gitlab.gnome.org/GNOME/orca/merge_requests/49> .
> > >           
> > >           I have been unavailable because of work/family obligations
> > >           since I made it, but have some more free time now and would
> > >           like to bring this to completion, if possible. Is there a
> > >           review process I need to follow to get this tested and merged?
> > >           
> > >           
> > >           Also, what's a good next issue for me to tackle? Is
> > >           
> > >           https://gitlab.gnome.org/GNOME/orca/issues/86
> > >           <https://gitlab.gnome.org/GNOME/orca/issues/86> a good
> > >           one to keep getting familiar with the code?
> > >           
> > >           
> > >           Thank you,
> > >           
> > >           Mike
> > >           
> > >           
> > >           
> > >           
> > >           _______________________________________________
> > >           
> > >           orca-list mailing list
> > >           
> > >           orca-list gnome org
> > >           
> > >           https://mail.gnome.org/mailman/listinfo/orca-list
> > >           
> > >           Orca wiki: https://wiki.gnome.org/Projects/Orca
> > >           
> > >           Orca documentation: https://help.gnome.org/users/orca/stable/
> > >           
> > >           GNOME Universal Access guide:
> > >           https://help.gnome.org/users/gnome-help/stable/a11y.html
> > >           
> > >           
> > >         
> >         
> >       
>       
>       _______________________________________________
>       
>       orca-list mailing list
>       
>       orca-list gnome org
>       
>       https://mail.gnome.org/mailman/listinfo/orca-list
>       
>       Orca wiki: https://wiki.gnome.org/Projects/Orca
>       
>       Orca documentation: https://help.gnome.org/users/orca/stable/
>       
>       GNOME Universal Access guide:
>       https://help.gnome.org/users/gnome-help/stable/a11y.html
>       
>