|
That's actually a good idea, unless you
have very valid and strongly justified reasons for disagreeing
with situations where your patches are not excepted and you still
feel they should have been there.
Happy hacking. Krishnakant. On 03/12/2014 12:52 AM, Mike Dupont wrote: I submitted code links to this list before, they still in github and I can rebase them if they are welcome. There are still many flake and lint issues still in the code. usage of eval, and other simple issues. Another thing that I noticed are the excessive usage of globals, the non standard logging, and also the package level variables for orcastate, all of these things I am willing to work on getting the code up to python standards and styles. I am willing to retry submitting patches and figuring out how to make them stick. mike On Tue, Mar 11, 2014 at 2:19 PM, Jarek Czekalski <jarekczek poczta onet pl>wrote:W dniu 03/11/2014 06:59 PM, Mike Dupont pisze: I will be updating https://github.com/h4ck3rm1k3/orca-sonar for now.I have also my original patchs for orca here which were ignored and are now out of date;Hi Mike I don't remember you sending any patches to orca. Could you give a link to the mailing list post or a bug report with the patch? By a patch we mean a diff file that fixes a single thing. Before writing a patch it's good to ask the maintainer, whether such a patch would be welcome. Then you post it for review. Jarek _______________________________________________ orca-list mailing list orca-list gnome org https://mail.gnome.org/mailman/listinfo/orca-list Visit http://live.gnome.org/Orca for more information on Orca. The manual is at http://library.gnome.org/users/gnome-access-guide/ nightly/ats-2.html The FAQ is at http://live.gnome.org/Orca/FrequentlyAskedQuestions Log bugs and feature requests at http://bugzilla.gnome.org Find out how to help at http://live.gnome.org/Orca/HowCanIHelp |