Re: [orca-list] Progress bar updates speak when not focused

[Willie Walker <William Walker Sun COM>]

Hi David:

Orca currently speaks the progress bar information if the application 
that owns the progress bar is active.  So, for example, if you've 
started a download in Firefox and move to OOo, the FF download progress 
should not be spoken.  If it is being spoken in this case, it is a bug.

However, it sounds as though perhaps you're working in Firefox, start a 
download, and continue surfing the web.  In this case, the download 
window no longer has focus, but Firefox is still the active application. 
 So, Orca is going to happily speak the progress bar information. :-( 
That sounds like a bug to me and a case we didn't account for.

Please do open a bug.  Please also test out the attached patch.  If it 
works, attach it to the bug you open and you'll get the credit for being 
a hero.  :-)  If it doesn't work, just blame me and call me an idiot. 
I'm used to it.  :-)

Will

David E. Price wrote:
> Hi,
>
> I would like to get a sense of the community's feel about this.
>
> Right now, if there is a progress bar in existence in any open program, 
> I get the update messages spoken every 10 seconds. I believe that 
> progress bar updates should only be spoken when the window/dialog 
> containing the progress bar has focus. To me, it is annoying that, 
> whenever I want to download something and continue working, I get an 
> update every 10 seconds or I have to go into the Orca preferences to 
> turn off the updates. I believe that requiring the progress bar's window 
> to have focus before any updates are indicated can allow users to avoid 
> a cluttered feedback environment.
>
> I'll file the RFE this weekend unless the rest of the community is 
> against the idea.
>
> thanks,
>
> dave
>
> _______________________________________________
> Orca-list mailing list
> Orca-list gnome org
> http://mail.gnome.org/mailman/listinfo/orca-list
> Visit http://live.gnome.org/Orca for more information on Orca

Index: src/orca/default.py
===================================================================
--- src/orca/default.py (revision 4622)
+++ src/orca/default.py (working copy)
@@ -2610,8 +2610,11 @@
         """
 
         if settings.enableProgressBarUpdates:
-            if orca_state.locusOfFocus and \
-               orca_state.locusOfFocus.getApplication() == obj.getApplication():
+            if orca_state.locusOfFocus \
+               and (orca_state.locusOfFocus.getApplication() \
+                    == obj.getApplication()) \
+               and (self.getTopLevel(obj) == self.findActiveWindow()):
+               
                 currentTime = time.time()
 
                 # Check for defunct progress bars. Get rid of them if they