Re: Orca A few more questions

[Jorge Sandin <jorges elsendero es>]

Hi Will! hi K.Nielsen!

> (Jorge - there's a question for you below...)
Firs of all, I'm here Will, I had no time at all these days, and the 
other bug I told you require a little of code (and it's not a "critical" 
bug), so I couldn't have it for today :(
But I'm here, an I'll be here, and it's on my todo list.


> > Hmm. Actually I may have blown this one. I forgot to mention that 
> > there is also this string right after:
> > "Use Mod.1"
> > #. MOD_USED1
> > #.
> > #: ../src/orca/orca_gui_prefs.py:133
> >
> > that would probably suggest that it should be translated. But in that 
> > case my original question remain. I'll wait for your reply.
>
> JORGE: there are a few strings flagged as needing translation in the 
> keybindings stuff:
>
> msgid "Mod.Mask 1"
> msgid "Use Mod.1"
> msgid "Key1"
> msgid "Mod.Mask 2"
> msgid "Use Mod.2"
> msgid "Key2"
>
> When I look at the UI, I don't see these strings.  Are they exposed to 
> the user?  If not, we should unmark them as needing translation.

Well, those strings are not exposed to the users in the GUI, the are 
columns ("fields") of the key bindings tab treeview, and are used, and 
that is the "description" of their fields (the text on the column 
header), but they are hidden now. Some of them were shown in previous 
versions, but not now (only 4 of them are visible, description, text1, 
text2, and modified). In fact I created text1 and text2 to have more 
flexibility for showing some of them to the user, instead of KEY1, 
MOD_USED1, etc.

So, they could be translated in case some day they become visible again 
(redesign?), but that's difficult task for the translator (I've been in 
that situation, and you feel completely lost some times, I know...).

...Or they could just been unmarked to be translated from the code 
directly, as the GUI doesn't seem to change by now. I send a trivial 
patch for this, attached :)

Anything about it, just tell me, I hope it's just on time :)

Jorge.

Index: /home/jorges/z/workspace/orcaSVN/src/orca/orca_gui_prefs.py
===================================================================
--- /home/jorges/z/workspace/orcaSVN/src/orca/orca_gui_prefs.py (revision 2053)
+++ /home/jorges/z/workspace/orcaSVN/src/orca/orca_gui_prefs.py (working copy)
@@ -100,7 +100,7 @@
 
         # HANDLER
         #
-        column = gtk.TreeViewColumn(_("Handler"),
+        column = gtk.TreeViewColumn("Handler",
                                     gtk.CellRendererText(),
                                     text=HANDLER)
         column.set_resizable(True)
@@ -120,7 +120,7 @@
 
         # MOD_MASK1
         #
-        column = gtk.TreeViewColumn(_("Mod.Mask 1"),
+        column = gtk.TreeViewColumn("Mod.Mask 1",
                                     gtk.CellRendererText(),
                                     text=MOD_MASK1)
         column.set_visible(False)
@@ -130,7 +130,7 @@
 
         # MOD_USED1
         #
-        column = gtk.TreeViewColumn(_("Use Mod.1"),
+        column = gtk.TreeViewColumn("Use Mod.1",
                                     gtk.CellRendererText(),
                                     text=MOD_USED1)
         column.set_visible(False)
@@ -140,7 +140,7 @@
 
         # KEY1
         #
-        column = gtk.TreeViewColumn(_("Key1"),
+        column = gtk.TreeViewColumn("Key1",
                                     gtk.CellRendererText(),
                                     text=KEY1)
         column.set_resizable(True)
@@ -168,7 +168,7 @@
 
         # MOD_MASK2
         #
-        column = gtk.TreeViewColumn(_("Mod.Mask 2"),
+        column = gtk.TreeViewColumn("Mod.Mask 2",
                                     gtk.CellRendererText(),
                                     text=MOD_MASK2)
         column.set_visible(False)
@@ -178,7 +178,7 @@
 
         # MOD_USED2
         #
-        column = gtk.TreeViewColumn(_("Use Mod.2"),
+        column = gtk.TreeViewColumn("Use Mod.2",
                                     gtk.CellRendererText(),
                                     text=MOD_USED2)
         column.set_visible(False)
@@ -188,7 +188,7 @@
 
         # KEY2
         #
-        column = gtk.TreeViewColumn(_("Key2"), rendererText, text=KEY2)
+        column = gtk.TreeViewColumn("Key2", rendererText, text=KEY2)
         column.set_resizable(True)
         column.set_visible(False)
         column.set_sort_column_id(KEY2)
@@ -232,7 +232,7 @@
         #
         rendererToggle = gtk.CellRendererToggle()
         rendererToggle.set_property('activatable',False)
-        column = gtk.TreeViewColumn(_("Modified"),
+        column = gtk.TreeViewColumn("Modified",
                                     rendererToggle,
                                     active=EDITABLE)
         column.set_visible(False)