Re: ORBit_small_get_connection ...

[Havoc Pennington <hp redhat com>]

Hi,

Just noticed your mail, I tend to not read all of orbit-list so 
sometimes I miss stuff.

On Fri, Apr 25, 2003 at 11:27:42AM +0100, Michael Meeks wrote:
> 
> 	So - I just did a quick grep of known hard-core ORBit2 users, and I hit
> GConf as the only code using this method.
> 
> 	The problem is - that the initial impl. didn't reference
> the object it returned; this really screws thread safety (obviously).
> I've committed a change to ORBit2 adding an
> ORBit_small_connection_unref() method; thinking that no-one was using it
> yet.
> 
> 	So - should I back that out and/or can we cope with this bin-incompat
> change [ it's quite nasty if the unref is not there, a largeish
> cumulative connection resource leak ;-].
> 
> 	Of course; we can add a ORBit_small_get_connection_ref method that does
> the right thing and migrate GConf to that ;-) how do people feel ?
> 

I'd generally feel we should add a new function that returns a
refcounted connection, rather than changing the existing function.
Adjusting gconf as required is no problem, feel free to go ahead and
commit such adjustments to HEAD.

Havoc