Re: New "tc qdisc" options

[Dave Collier-Brown <dave collier-brown indexexchange com>]

I can absolutely propose a patch/MR based on that example, but I'm
fallible (;-))

Do you prefer an MR in github or a git-format-patch via email?

--dave

On 2020-10-05 10:32 a.m., Beniamino Galvani wrote:
> On Mon, Oct 05, 2020 at 06:35:19AM -0400, Dave Collier-Brown via networkmanager-list wrote:
> > > > I see code in
> > > >
> > > > https://gitlab.freedesktop.org/NetworkManager/NetworkManager/blob/master/libnm-core/nm-setting-tc-config.c
> > > >
> > > > which implements setting tc qdisc, and a brief mention in
> > > >
> > > > https://developer.gnome.org/NetworkManager/stable/
> > > >
> > > > However the man pages do not mention tc.
> > > >
> > > > Can you provide a hint on setting, for example, /tc qdisc replace dev
> > > > enp0s25 root cake bandwidth 20mbit/ in network manager?
> > > "cake" is currently not supported. Until that is added, the intended
> > > solution is to use a dispatcher script. See `man NetworkManager`.
> > Alas, that's the first place I looked (:-()
> >
> > Cake doesn't need to be supported in network manager, as I can work
> > around it's lack with fq_codel.
> >
> > However, I do need to discover the location and notation interpreted by
> > nm-setting-tc-config.c
> >
> > 1) can you help me with that?
> To configure fq_codel, you can use nmcli in this way:
>
>   $ nmcli connection modify $myconnection tc.qdiscs \
>           "root fq_codel limit 2000 target 3000 interval 40000"
>
>   $ nmcli connection up $myconnection
>
>   $ tc qdisc show dev $mydev
>   qdisc fq_codel 8003: root refcnt 2 limit 2000p flows 1024 quantum 1514 target 3.0ms interval 40.0ms 
> memory_limit 32Mb ecn
>
> > 2) is adding (the name of) the cake qdisc on your backlog?
> Currently NM doesn't support configuring CAKE parameters. IOW, if you
> set "root cake bandwidth 100Mbit", you will see in the tc output that
> cake was set but with default parameters.
>
> Yes, I think it will be useful to have CAKE support in NM, but I can't
> say when it will be implemented. Of course, patches are always
> welcome; if anybody is interested in contributing it, please have a
> look at the work that was done to support SFQ:
>
> https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b22b4f9101b1cbfde49b65d9e2107e4ae0d817c0
>
> Beniamino

--
David Collier-Brown,         | Always do right. This will gratify
System Programmer and Author | some people and astonish the rest
dave collier-brown indexexchange com |              -- Mark Twain


CONFIDENTIALITY NOTICE AND DISCLAIMER : This telecommunication, including any and all attachments, contains 
confidential information intended only for the person(s) to whom it is addressed. Any dissemination, 
distribution, copying or disclosure is strictly prohibited and is not a waiver of confidentiality. If you 
have received this telecommunication in error, please notify the sender immediately by return electronic mail 
and delete the message from your inbox and deleted items folders. This telecommunication does not constitute 
an express or implied agreement to conduct transactions by electronic means, nor does it constitute a 
contract offer, a contract amendment or an acceptance of a contract offer. Contract terms contained in this 
telecommunication are subject to legal review and the completion of formal documentation and are not binding 
until same is confirmed in writing and has been signed by an authorized signatory.