Re: [RFC PATCH 1/2] platform: move genl_ctrl_resolve to nm-netlink.c
- From: Javier Arteaga <jarteaga jbeta is>
- To: Thomas Haller <thaller redhat com>
- Cc: "Jason A. Donenfeld" <Jason zx2c4 com>, Maximilian Moser <e1326252 student tuwien ac at>, networkmanager-list gnome org
- Subject: Re: [RFC PATCH 1/2] platform: move genl_ctrl_resolve to nm-netlink.c
- Date: Wed, 14 Mar 2018 11:53:45 +0000
On Wed, Mar 14, 2018 at 11:35 AM, Thomas Haller <thaller redhat com> wrote:
Hi,
-out:
- if (result >= 0)
- _LOGD (LOGD_WIFI, "genl_ctrl_resolve: resolved
\"%s\" as 0x%x", name, result);
- else
- _LOGE (LOGD_WIFI, "genl_ctrl_resolve: failed resolve
\"%s\"", name);
- return result;
while moving the code, you (rightly) dropped the logging.
Could you log for the error case at src/platform/wifi/wifi-utils-
nl80211.c (_LOGD() level is enough).
Sure - will do that for v2.
Thanks!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]