Re: [RFC PATCH 1/2] platform: move genl_ctrl_resolve to nm-netlink.c

On Wed, 2018-03-14 at 00:03 +0000, Javier Arteaga wrote:
Move genl_ctrl_resolve out of the wifi code so it can be reused by
interfaces based on genetlink.


-     if (result >= 0)
-             _LOGD (LOGD_WIFI, "genl_ctrl_resolve: resolved
\"%s\" as 0x%x", name, result);
-     else
-             _LOGE (LOGD_WIFI, "genl_ctrl_resolve: failed resolve
\"%s\"", name);
-     return result;

while moving the code, you (rightly) dropped the logging.

Could you log for the error case at src/platform/wifi/wifi-utils-
nl80211.c (_LOGD() level is enough).


Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]