[RFC PATCH 0/2] platform: add WireGuard support



Hi all,

After following Max's WireGuard VPN NM plugin effort [1] and reading the
follow-up discussion on this list [2], I've been spending some spare
time on non-VPN WireGuard integration.

This patchset is a very rough draft. Only querying and parsing of
existing WireGuard interfaces via genetlink is implemented. I'm a newbie
on multiple fronts here (NetworkManager, glib and WireGuard itself) so
at this point I really need feedback to see if this is going anywhere
near the right direction.

I have a few questions already:

- Is it a good idea to map `Peer` and `AllowedIP` to new NMPObjects?
  Particularly AllowedIP feels strange - it's just an addr+mask so
  there could be something more suitable already within NM.

- Should the wireguard-specific genetlink parsing be moved elsewhere,
  e.g. src/platform/wireguard/ ?

Thanks!

Link: https://github.com/max-moser/network-manager-wireguard/ [1]
Link: https://mail.gnome.org/archives/networkmanager-list/2018-February/msg00017.html [2]

Javier Arteaga (2):
  platform: move genl_ctrl_resolve to nm-netlink.c
  platform: add support for WireGuard links

 src/nm-types.h                         |   5 +
 src/platform/nm-linux-platform.c       | 250 +++++++++++++++++++++++++++++++++
 src/platform/nm-netlink.c              |  68 +++++++++
 src/platform/nm-netlink.h              |  32 +++--
 src/platform/nm-platform.c             |  97 +++++++++++++
 src/platform/nm-platform.h             |  44 ++++++
 src/platform/nmp-object.c              |  25 ++++
 src/platform/nmp-object.h              |  21 +++
 src/platform/wifi/wifi-utils-nl80211.c |  80 -----------
 9 files changed, 527 insertions(+), 95 deletions(-)

-- 
2.16.2



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]