Re: [PATCH 2/3] nm-c-e: Proxy Page Implementation.

On Tue, 2016-07-12 at 18:00 +0530, Atul Anand wrote:
This Patch implements the Proxy page GUI. Conventional GUI has been
implemented which people generally see in Browsers. Exception being
there is a separate page for each of the connection whether active
or inactive.

+ * Atul Anand <atulhjp gmail com>

"(C) Copyright 2016 Atul Anand <atulhjp gmail com>." please.

+     /* Method */
+     method = gtk_combo_box_get_active (priv->method);
+     switch (method) {
+             nm_connection_remove_setting (CE_PAGE (self)->connection, NM_TYPE_SETTING_PROXY);
+             priv->setting = (NMSettingProxy *) nm_setting_proxy_new ();
+             nm_connection_add_setting (CE_PAGE (self)->connection, NM_SETTING (priv->setting));
+             /* Update NMSetting */
+             g_object_set (priv->setting,
+                           NULL);
+             break;

Wouldn't it be a better idea to omit the proxy setting altogether when
the method is NONE?

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]