Re: [PATCH 2/3] nm-c-e: Proxy Page Implementation.

On 7/26/16, Lubomir Rintel <lkundrak v3 sk> wrote:
On Tue, 2016-07-12 at 18:00 +0530, Atul Anand wrote:
This Patch implements the Proxy page GUI. Conventional GUI has been
implemented which people generally see in Browsers. Exception being
there is a separate page for each of the connection whether active
or inactive.

+ * Atul Anand <atulhjp gmail com>

"(C) Copyright 2016 Atul Anand <atulhjp gmail com>." please.

+    /* Method */
+    method = gtk_combo_box_get_active (priv->method);
+    switch (method) {
+            nm_connection_remove_setting (CE_PAGE (self)->connection,
+            priv->setting = (NMSettingProxy *) nm_setting_proxy_new ();
+            nm_connection_add_setting (CE_PAGE (self)->connection, NM_SETTING
+            /* Update NMSetting */
+            g_object_set (priv->setting,
+                          NULL);
+            break;

Wouldn't it be a better idea to omit the proxy setting altogether when
the method is NONE?

I don't know but we are creating PROXY_METHOD=none variable in ifcfg
network script. So if we omit proxy setting on NONE then i guess proxy
tab wouldn't appear in nm-c-e after setting NONE and rebooting the
connection . ifcfg reader won't read anything .

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]