Re: [PATCH 3/3] nm-c-e: UI file for Proxy Tab

[Lubomir Rintel <lkundrak v3 sk>]

On Tue, 2016-07-12 at 18:00 +0530, Atul Anand wrote:
> UI file for 'Proxy' tab contain entries/widgets for the three mode c-e
> is offering. On setting mode 'none' nothing is pushed inside PacRunner
> (only exception being Domains which is sent for all modes). In mode 'auto'
> Pac Url or/and Pac Script can be inserted which PacRunner handles in an
> order. The 'manual' mode gives entries for different protocols and an
> entry for adding no-proxy-for (excludes) for that specific connection.
> ---
>  src/connection-editor/ce-page-proxy.ui | 475 +++++++++++++++++++++++++++++++++
>  1 file changed, 475 insertions(+)
>  create mode 100644 src/connection-editor/ce-page-proxy.ui
>
> diff --git a/src/connection-editor/ce-page-proxy.ui b/src/connection-editor/ce-page-proxy.ui
> new file mode 100644
> index 0000000..fe63c43
> --- /dev/null
> +++ b/src/connection-editor/ce-page-proxy.ui
> @@ -0,0 +1,475 @@
> +
> +<!-- Generated with glade 3.19.0 -->

3.4 please.

> +  
> +    True
> +    False
> +    12
> +    vertical
> +    <property name="spacing">18</property>

This is a bit too spacey. I think we use 6 elsewhere?

> +      
> +        Default
> +        True
> +        True
> +        False
> +        Make HTTP proxy default for all protocols.
> +        100
> +        <property name="xalign">0</property>

This is deprecated. Please use <property name="halign">start</property>
instead.

> +    
> +      
> +        SOCKS v5
> +        True
> +        True
> +        False
> +        Default is SOCKS v4.
> +        100
> +        <property name="xalign">2.2351741291171123e-10</property>

<property name="halign">start</property> instead please.

Lubo