Re: ANN: NetworkManager 0.9.9.98 (0.9.10-rc1) released

[Vincent Bernat <bernat luffy cx>]

 ❦ 26 juin 2014 12:06 -0500, Dan Williams <dcbw redhat com> :

> -#PKG_CHECK_MODULES(READLINE, readline)
> -AC_CHECK_LIB(readline, readline, [READLINE_LIBS=-lreadline], [AC_MSG_ERROR(readline library is required)])
> -AC_CHECK_HEADERS(readline/readline.h, [], [AC_MSG_ERROR(readline/readline.h - readline devel files 
> required)])
> +AX_LIB_READLINE
> +READLINE_LIBS="$LIBS"
>  AC_SUBST(READLINE_LIBS)

I don't think you should set READLINE_LIBS here.

> +  AC_CHECK_HEADERS(history.h readline/history.h)
> +  READLINE_LIBS="$ax_cv_lib_readline"

You set it here.

Otherwise, this looks fine.
-- 
Use data arrays to avoid repetitive control sequences.
            - The Elements of Programming Style (Kernighan & Plauger)