On 03/06/2013 10:06, Aleksander Morgado wrote:
On 02/06/13 16:32, Graham Inggs wrote:The attached patch allows ModemManager to detect the Huawei E3276. It also defaults to IPv4 if the bearer ip_type is not specified, does not send encoded_auth if it is zero, and sends the short form AT^NDISDUP=1,1 if the username and password are both blank.Can you split the patch into several ones, one for each changed functionality? That would be better for reviewing.
Sure. Attached patch huawei-e3276-port-types.diff allows the Huawei E3276 ports to be detected. Patch huawei-bearer-default-to-ipv4.diff lets ip_type default to IPv4 if it is not specified. Without this patch, I was not able to establish an AT^NDISDUP connection with any modem. Lastly, huawei-bearer-e3276-support.diff adds support for the Huawei E3276 by sending the shortened form of the AT^NDISDUP command where possible, as the E3276 fails with an '+CME ERROR: Incorrect parameters' if encoded_auth is set to 0. This behaviour is slightly different to the E1820 and K4605 (E372) which will happily establish a connection with encoded_auth set to 0, 1 or 2. ________________________________ UNIVERSITY OF CAPE TOWN This e-mail is subject to the UCT ICT policies and e-mail disclaimer published on our website at http://www.uct.ac.za/about/policies/emaildisclaimer/ or obtainable from +27 21 650 9111. This e-mail is intended only for the person(s) to whom it is addressed. If the e-mail has reached you in error, please notify the author. If you are not the intended recipient of the e-mail you may not use, disclose, copy, redirect or print the content. If this e-mail is not related to the business of UCT it is sent by the sender in the sender's individual capacity.
Attachment:
huawei-e3276-port-types.diff
Description: Text Data
Attachment:
huawei-bearer-default-to-ipv4.diff
Description: Text Data
Attachment:
huawei-bearer-e3276-support.diff
Description: Text Data