RE: [MM] Problem Huawei E303

["Gonzalez Calabozo, Jose Maria" <jmgonzalezc indra es>]

Hi!
It works!!!
Now the Modem Manager always detects the Huawei e303. :)

But with this version I have a compilation warning.
I get the next error:

make[3]: Entering directory `/home/jose/modemmanager/ModemManager/src'
  CC       ModemManager-mm-plugin.o
mm-plugin.c: In function ‘mm_plugin_supports_port’:
mm-plugin.c:753:20: error: ‘probe’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[3]: *** [ModemManager-mm-plugin.o] Error 1
make[3]: Leaving directory `/home/jose/modemmanager/ModemManager/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/jose/modemmanager/ModemManager/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/jose/modemmanager/ModemManager'
make: *** [all] Error 2


I have solved it by asigning a NULL value to probe on startup, but I don't know if that is the propper way to 
fix it:

index 4616e9d..06efc2d 100644
--- a/src/mm-plugin.c
+++ b/src/mm-plugin.c
@@ -629,7 +629,7 @@ mm_plugin_supports_port (MMPlugin *self,
                          GAsyncReadyCallback callback,
                          gpointer user_data)
 {
-    MMPortProbe *probe;
+    MMPortProbe *probe = NULL;
     GSimpleAsyncResult *async_result;
     PortProbeRunContext *ctx;
     gboolean need_vendor_probing;

________________________________________
De: Aleksander Morgado [aleksander lanedo com]
Enviado el: miércoles, 20 de febrero de 2013 19:37
Para: Gonzalez Calabozo, Jose Maria
CC: networkmanager-list gnome org
Asunto: Re: [MM] Problem Huawei E303

> > I have found another issue that I am not sure if it is a bug or not. It seems that the ModemManager cannot 
> > detect the first time that I insert the modem.
> > > After try with many ports it prints the next lines:
> > > ModemManager[7749]: <debug> [1361368039.448167] [mm-serial-port.c:994] mm_serial_port_close(): (ttyUSB0) 
> > > device open count is 0 (close)
> > > ModemManager[7749]: <debug> [1361368039.448198] [mm-serial-port.c:1010] mm_serial_port_close(): 
> > > (ttyUSB0) closing serial port...
> > > ModemManager[7749]: <debug> [1361368039.449123] [mm-serial-port.c:1041] mm_serial_port_close(): 
> > > (ttyUSB0) serial port closed
> > > ModemManager[7749]: <debug> [1361368039.449164] [mm-serial-port.c:1109] mm_serial_port_close_force(): 
> > > (ttyUSB0) forced to close port
> > > ModemManager[7749]: <debug> [1361368039.449231] [mm-plugin-manager.c:352] plugin_supports_port_ready(): 
> > > (Plugin Manager) (Huawei) [ttyUSB0] found best plugin for port
> > > ModemManager[7749]: <debug> [1361368039.449274] [mm-plugin-manager.c:238] port_probe_context_finished(): 
> > > (Plugin Manager) 'ttyUSB0' port probe finished, last one in device, but minimum probing time not 
> > > consumed yet ('24.443516' seconds elapsed)
> > >
> > > But If I unplug and plug it again it will recognize the modem.
> Ah, my heisenbug. Yes, I've been the whole morning trying to reproduce
> it after I saw it yesterday. We configure a timeout to be run 2s after
> we initialize the device probing, but for some reason it doesn't get
> fired. Nice to see that I'm not the only one seeing it, will try to
> track it down these days. Do you have a full debug log of this issue
> happening? Or just that snippet?

Pushed a fix to handle this issue; let me know if you see it again.

Cheers!

--
Aleksander

Este correo electrónico y, en su caso, cualquier fichero anexo al mismo, contiene información de carácter 
confidencial exclusivamente dirigida a su destinatario o destinatarios. Si no es vd. el destinatario 
indicado, queda notificado que la lectura, utilización, divulgación y/o copia sin autorización está prohibida 
en virtud de la legislación vigente. En el caso de haber recibido este correo electrónico por error, se ruega 
notificar inmediatamente esta circunstancia mediante reenvío a la dirección electrónica del remitente.
Evite imprimir este mensaje si no es estrictamente necesario.

This email and any file attached to it (when applicable) contain(s) confidential information that is 
exclusively addressed to its recipient(s). If you are not the indicated recipient, you are informed that 
reading, using, disseminating and/or copying it without authorisation is forbidden in accordance with the 
legislation in effect. If you have received this email by mistake, please immediately notify the sender of 
the situation by resending it to their email address.
Avoid printing this message if it is not absolutely necessary.