Re: Fwd: [ISSUE] Modem manager SMS storages assert

[Aleksander Morgado <aleksander lanedo com>]

> Dear Dan,
> Because there may be more than 1 UNKNOWN SMS storages in the array, 
> so just once skipping still got the same assert. 
> I have tried patch below and it works well until now.
>
> --- /home/user/桌面/ModemManager-1.0.0/src/mm-iface-modem-
> messaging.c2013-07-19 16:00:01.000000000 +0800
> +++
> /home/user/ModemManager-1.0.0/src/mm-iface-modem-messaging.c2013-08-08
> 16:10:30.004191341 +0800
> @@ -795,13 +795,29 @@
>  
>      if (!storage_ctx->supported_mem1 || ctx->mem1_storage_index >=
> storage_ctx->supported_mem1->len)
>          all_loaded = TRUE;
> -    /* We'll skip the 'MT' storage, as that is a combination of 'SM'
> and 'ME' */
> -    else if (g_array_index (storage_ctx->supported_mem1,
> -                            MMSmsStorage,
> -                            ctx->mem1_storage_index) ==
> MM_SMS_STORAGE_MT) {
> -        ctx->mem1_storage_index++;
> -        if (ctx->mem1_storage_index >= storage_ctx->supported_mem1->len)
> -            all_loaded = TRUE;
> +    /* We'll skip the 'MT' storage, as that is a combination of 'SM' and
> +     * 'ME'. Also skip unknown storages since they can't be handled.

Instead of this, we should probably just make sure that when loading
supported storages we never add MM_SMS_STORAGE_UNKNOWN, which is
pointless to add.

-- 
Aleksander