Re: [MM] [PATCH] sierra: add support for new !SELRAT values in newer Sierra LTE modems
- From: Marius Kotsbak <marius kotsbak gmail com>
- To: Dan Williams <dcbw redhat com>
- Cc: "networkmanager-list gnome org" <networkmanager-list gnome org>
- Subject: Re: [MM] [PATCH] sierra: add support for new !SELRAT values in newer Sierra LTE modems
- Date: Sat, 8 Sep 2012 00:49:15 +0200
2012/9/7 Dan Williams
<dcbw redhat com>
On Mon, 2012-09-03 at 18:24 +0200, Marius Kotsbak wrote:
> Patch attached again in right format.
Backported and pushed to 0.6.
Great! Now it seems we just need to add support for 4G preference in nm-applet to actually use this?
The backport is though slightly wrong:
case MM_MODEM_GSM_ALLOWED_MODE_2G_PREFERRED:
idx = 4;
break;
case MM_MODEM_GSM_ALLOWED_MODE_3G_PREFERRED:
idx = 3;
break;
Modes 3 and 4 will include LTE, so it is probably better to use mode 5 for both of these (and maybe refuse 2G preferred) for LTE modem, else it is impossible to select 2G/3G mode (exclude LTE).
And it is still unclear if mode 7 actually means LTE preferred, or if it just behaves as mode 0, but we can leave it like that for now so that it is possible to select it.
--
Marius
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]