Re: review request: pavlix/build



On Sat, 2012-10-27 at 19:39 -0400, Pavel Simerda wrote:
> Hi,
> 
> I just pushed an updated version of 'pavlix/build', rebased to the current
> master. It's still a singe patch:
> 
> http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?h=pavlix/build&id=4dd911361871f8b8407f4f1c5deaf7422f4f76f8

The commit message here says "what", but not *why*.  What's the
motivation for making the change?  e.g. Look prettier in the filesystem?
That's a valid motivation, but should be stated in the commit.

Or your comment kind of implies it might be done to make it easier to
write e.g. SELinux or AppArmor policy?  In that case, also worth stating
explicitly.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]