Re: [PATCH](or feature-request) build both systemd and ck versions



> Pavel Simerda wrote:
> > In my opinion, you should have just one binary. It is easy to
> > detect systemd
> > at runtime, as it requires cgroups and creates one. Symlink
> > management is
> > an overkill here. CK should be likewise very easy to detect. In
> > absence of
> > both, NetworkManager should still work.
> 
> For the most part, I agree with you.
> 
> I think the best argument against a single binary is that currently
> for systemd support it must be linked against `libsystemd-login`,
> which a non-systemd user might not have.

This is not an argument against a single binary at all. If you don't
have the dependency, just don't build in the systemd part. You can
even end up with a binary that supports neither of them, if applicable.

> But really, that is a "long-term" change, I am advocating producing
> both versions as they currently exist.  What this patch does is the
> same thing as if I built it twice with different configure flags;
> there is no modification to NetworkManager itself, just the build
> system.

Yes, and I believe this sort of modification to the build system is
unwelcome and the product of it (the two binaries) likewise.

Pavel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]