Re: [PATCH](or feature-request) build both systemd and ck versions



At Thu, 18 Oct 2012 05:19:57 -0400 (EDT),
Pavel Simerda wrote:
> In my opinion, you should have just one binary. It is easy to detect systemd
> at runtime, as it requires cgroups and creates one. Symlink management is
> an overkill here. CK should be likewise very easy to detect. In absence of
> both, NetworkManager should still work.

For the most part, I agree with you.

I think the best argument against a single binary is that currently
for systemd support it must be linked against `libsystemd-login`,
which a non-systemd user might not have.

But really, that is a "long-term" change, I am advocating producing
both versions as they currently exist.  What this patch does is the
same thing as if I built it twice with different configure flags;
there is no modification to NetworkManager itself, just the build
system.

~ Luke Shumaker


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]