Re: [mm][PATCH 1/5] novatel: Add support for connecting to specific APNs and specifying username/password.
- From: Nathan Williams <njw google com>
- To: Aleksander Morgado <aleksander lanedo com>
- Cc: networkmanager-list gnome org
- Subject: Re: [mm][PATCH 1/5] novatel: Add support for connecting to specific APNs and specifying username/password.
- Date: Wed, 2 May 2012 10:43:42 -0400
On Wed, May 2, 2012 at 10:43 AM, Nathan Williams <njw google com>
On 05/01/2012 06:07 PM, Nathan Williams wrote:
> Subject: [PATCH 1/5] novatel: Add support for connecting to specific APNs and
> specifying username/password.
> While here, pass through the other relevant bearer properties.
Did you have time to check the 'bearer-properties' branch I wrote about
some time ago? That branch makes it unnecessary to have bearers
implement user/password properties themselves.
It certainly seemed like a good idea, and would simplify this, but I didn't think it had been merged. I hope you hadn't been waiting on me....
> + apn = mm_at_serial_port_quote_string
> + user = mm_at_serial_port_quote_string (self->priv->user);
> + password = mm_at_serial_port_quote_string (self->priv->password);
> + command = g_strdup_printf ("$NWQMICONNECT=,,,,,,%s,,,%s,%s",
> + apn, user, password);
mm_at_serial_port_quote_string() is not in git master yet. I remember a
thread talking about quoting strings, but don't recall getting a patch
about it. Could you also post that one?
Will do. I had forgotten that I was using it in both of my plugins, and meant to include it in the stack with my Samsung changes.
] [Thread Prev