Re: [mm][PATCH 1/5] novatel: Add support for connecting to specific APNs and specifying username/password.

[Aleksander Morgado <aleksander lanedo com>]

Hey Nathan,

On 05/01/2012 06:07 PM, Nathan Williams wrote:
> Subject: [PATCH 1/5] novatel: Add support for connecting to specific APNs and
>  specifying username/password.
> 
> While here, pass through the other relevant bearer properties.

Did you have time to check the 'bearer-properties' branch I wrote about
some time ago? That branch makes it unnecessary to have bearers
implement user/password properties themselves.

> +    apn = mm_at_serial_port_quote_string
(mm_broadband_bearer_get_3gpp_apn (bearer));
> +    user = mm_at_serial_port_quote_string (self->priv->user);
> +    password = mm_at_serial_port_quote_string (self->priv->password);
> +    command = g_strdup_printf ("$NWQMICONNECT=,,,,,,%s,,,%s,%s",
> +                               apn, user, password);

mm_at_serial_port_quote_string() is not in git master yet. I remember a
thread talking about quoting strings, but don't recall getting a patch
about it. Could you also post that one?

Cheers,

-- 
Aleksander