Re: ModemManager interface headers: MM1_ vs MM_

[Dan Williams <dcbw redhat com>]

On Thu, 2012-03-22 at 18:54 +0100, Aleksander Morgado wrote:
> >> The ChromeOS connection manager would like to talk with both old-style
> >> ModemManager (org.freedesktop.ModemManager) and new-style ModemManager
> >> (org.freedesktop.ModemManager1) modem managers at the same time.
> >>
> >> Unfortunately, the old header (mm-modem.h) is not compatible with the
> >> new headers (ModemManager-*.h). For example, both define
> >> MM_MODEM_CDMA_REGISTRATION_STATE_*.
> >>
> >> Consistency suggests that we should name all the exported ModemManager1
> >> interfaces and enums MM1_. I'm happy to put up a CL for this, but I'd
> >> like to solicit opinions before I sharpen up my search/replace knives.
> >>
> >
> > Hum... it indeed is an issue, but I wonder how many enums are defined
> > with the same name in both old and new headers; IIRC they were not many,
> > maybe 2 or 3. If they are really not many, I would personally prefer to
> > rename the enums themselves with a similar but not equal name... Having
> > mixed mm_ and mm1_ prefixes along the core code doesn't look very well.
> >
> 
> That could just be renaming enums starting with "MMModemSomething" to 
> just "MMSomething" (e.g. MMModemCdmaRegistrationState could be 
> MMCdmaRegistrationState).
> 
> Exceptions in the rename could be MMModemState, MMModemStatechangeReason 
> and MMModemMode, which really need the Modem keyword.

I don't have a strong feeling here, but MM vs. MM1 can get hard to read.
i.e. if you're scanning code, MMModemState vs. MM1ModemState doesn't
look all that different.

Dan