Re: ModemManager interface headers: MM1_ vs MM_

[Aleksander Morgado <aleksander lanedo com>]

> The ChromeOS connection manager would like to talk with both old-style
> ModemManager (org.freedesktop.ModemManager) and new-style ModemManager
> (org.freedesktop.ModemManager1) modem managers at the same time.
>
> Unfortunately, the old header (mm-modem.h) is not compatible with the
> new headers (ModemManager-*.h).  For example, both define
> MM_MODEM_CDMA_REGISTRATION_STATE_*.
>
> Consistency suggests that we should name all the exported ModemManager1
> interfaces and enums MM1_.   I'm happy to put up a CL for this, but I'd
> like to solicit opinions before I sharpen up my search/replace knives.

Hum... it indeed is an issue, but I wonder how many enums are defined 
with the same name in both old and new headers; IIRC they were not many, 
maybe 2 or 3. If they are really not many, I would personally prefer to 
rename the enums themselves with a similar but not equal name... Having 
mixed mm_ and mm1_ prefixes along the core code doesn't look very well.

As for the interface names (those in ModemManager-names.h), it's not a 
big deal. Given that the names are autogenerated from the ModemManager1 
interface, sounds good to have them prefixed with MM1_.

--
Aleksander