Re: [MM] [PATCH 1/3] ZTE modem ignores everything after ATZ command in init string

Too many different issues in the same email :-) It is much better to
provide separate patches/emails for different issues, so that they can
be discussed in different threads and followed separately.

Aleksander, thank you for your reply. I reworked my patches, and do as
you said: provide patches in several emails. This is the first.

While initializing, my modem ZTE MF192 ignores everything in init string
after ATZ command. This patch breaks initialization command into two
pieces: ATZ and everything else.

ITU rec v.250 (6.1.1) actually says: "The DTE should not include additional commands on the same command line after the Z command because such commands may be ignored." (Thanks to Nathan for that tip.)

So we should probably just do that in every case, not just for the ZTE plugin. The Iridium plugin also needs that, for example.

--- a/plugins/mm-modem-zte.c	2012-03-13 23:06:11.000000000 +0400
+++ b/plugins/mm-modem-zte.c	2012-04-15 15:15:41.680026936 +0400
@@ -471,7 +471,8 @@
      } else {
          /* Finish the initialization */
          mm_modem_icera_is_icera (MM_MODEM_ICERA (self), icera_check_cb,
-        mm_at_serial_port_queue_command (port, "Z E0 V1 X4&C1 +CMEE=1;
+CFUN=1;", 10, init_modem_done, info);
+        mm_at_serial_port_queue_command (port, "Z", 5, NULL, NULL);
+        mm_at_serial_port_queue_command (port, "E0 V1 X4&C1 +CMEE=1;
+CFUN=1;", 10, init_modem_done, info);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]