Re: [PATCH 4/8] ethernet: Move all connection <-> device matching into a single function
- From: Thomas Graf <tgraf redhat com>
- To: Dan Williams <dcbw redhat com>
- Cc: networkmanager-list gnome org
- Subject: Re: [PATCH 4/8] ethernet: Move all connection <-> device matching into a single function
- Date: Tue, 22 Nov 2011 11:06:54 +0100
On Mon, 2011-11-21 at 23:44 -0600, Dan Williams wrote:
> On Mon, 2011-11-21 at 17:50 +0100, Thomas Graf wrote:
> > Moves all code to match an ethernet connection into a single function
> > match_ethernet_connection() and use it from everywhere within
> > NMDeviceEthernet.
>
> Looks good pending the outcome of the connection/interface patch. Note
> that danw's IPoIB patches will conflict with this, do you want to wait
> for that to merge (I can do that ASAP) or do you want me to rebase his
> stuff on top of this one? (he splits up NMDeviceEthernet into an
> abstract NMDeviceWired and a concrete NMDeviceEthernet so that
> NMDeviceInfiniband can be a subclass of NMDeviceWired).
Either is fine with me. Merge in the order that is easiest for you. I
will watch master and rebase/repost as needed.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]