Re: [PATCH 4/8] ethernet: Move all connection <-> device matching into a single function

[Dan Winship <danw gnome org>]

On 11/22/2011 12:44 AM, Dan Williams wrote:
> On Mon, 2011-11-21 at 17:50 +0100, Thomas Graf wrote:
>> Moves all code to match an ethernet connection into a single function
>> match_ethernet_connection() and use it from everywhere within
>> NMDeviceEthernet.
> 
> Looks good pending the outcome of the connection/interface patch.  Note
> that danw's IPoIB patches will conflict with this, do you want to wait
> for that to merge (I can do that ASAP) or do you want me to rebase his
> stuff on top of this one?  (he splits up NMDeviceEthernet into an
> abstract NMDeviceWired and a concrete NMDeviceEthernet so that
> NMDeviceInfiniband can be a subclass of NMDeviceWired).

There will need to be a little bit of additional work beyond the
reorganization to get infiniband bonding to work as well, so it might
make sense to land bonding first? (Or not. I guess we could land base
ipoib first, then ethernet bonding, then ipoib bonding later.)

(FWIW, I'm gone for the rest of this week and then at the WebKitGTK
hackfest next week, so I won't be hacking on ipoib much for the next two
weeks.)

-- Dan