Re: [PATCH 2/8] bonding: Add nm_connection_get_iface_name() to abstract kernel interface binding

[Thomas Graf <tgraf redhat com>]

On Mon, 2011-11-21 at 18:24 -0600, Dan Williams wrote:

> > @@ -909,12 +893,9 @@ real_get_best_auto_connection (NMDevice *dev,
> >  
> >  		connection_type = nm_setting_connection_get_connection_type (s_con);
> >  
> > -		if (!strcmp (connection_type, NM_SETTING_BOND_SETTING_NAME)) {
> > -			if (nm_device_bond_connection_matches (dev, connection))
> > -				return connection;
> > -
> > +		iface = nm_connection_get_iface_name (candidate);
> > +		if (iface && strcmp (nm_device_get_iface (dev), iface))
> 
> g_strcmp0() is NULL safe.

Actually in this specific situation we can't because we want to skip the
connection if a virtual iface has been specified but it does not match.