Re: [PATCH 8/8] bonding: Move bonding master state to UNAVAILABLE regardless of carrier state

[Thomas Graf <tgraf redhat com>]

On Mon, 2011-11-21 at 23:40 -0600, Dan Williams wrote:
>  
> > +	if (!strcmp(nm_device_get_driver (self), "bonding"))
> > +		priv->type = NM_ETHERNET_TYPE_BOND;
> > +	else
> > +		priv->type = NM_ETHERNET_TYPE_UNSPEC;
> 
> That part is somewhat icky; we could create a new private GObject
> property (ie, NM_PROPERTY_PARAM_NO_EXPORT) for the device type and pass
> that in when the device is created.  No strong feelings on this now
> though, we could leave that for a later cleanup as long as we put a
> FIXME comment there.

Agreed, this would be cleaner. I will put a FIXME in for now and work
on it after the bonding implementation is complete. It would be ideal
to also include PPPoE in the enum to ease all the PPPoE special cases.
I haven't looked at the IPoB code yet.