Re: [PATCH] modem: map modemmanager errors more detailed

[Thomas Bechtold <thomasbechtold jpberlin de>]

On 15/11/11 00:32, Dan Williams wrote:
> > - in NM/include/NetworkManager.h are some NMDeviceStateReason defined
> >    which are never used. eg NM_DEVICE_STATE_REASON_MODEM_NO_DIAL_TONE,
> >    NM_DEVICE_STATE_REASON_MODEM_NO_CARRIER,
> >    NM_DEVICE_STATE_REASON_MODEM_DIAL_FAILED,
> >    NM_DEVICE_STATE_REASON_GSM_APN_FAILED,
> >    NM_DEVICE_STATE_REASON_GSM_PIN_CHECK_FAILED
> >    maybe there are some more unused NMDeviceStateReason.
> >    Why are these reason available?
>
> Because we thought they'd be used, but turned out they aren't used yet.
> Some of them just never got hooked up.

Then we should remove the Reasons for the 1.0 release, right?


Tom